Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config file including all options #172

Merged
merged 1 commit into from
Jan 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

51 changes: 51 additions & 0 deletions p11nethsm.example.conf
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
# Set this option to true to enable the compatibility option for the C_SetAttributeValue() function.
# This allows the applications using the Java Sun PKCS11 module (like EJBCA) to generate keys.
# When using this, the names given to the keys will be ignored and the keys will have random names.
# Under the hood it will store in memory the name given to the key when calling C_SetAttributeValue(). When a certificate is uploaded it will check if the name was previously passed to C_SetAttributeValue() and translate it to the real name on the NetHSM.
enable_set_attribute_value: false

# You can set the log file location here.
# If no value is set the module will output to stderr.
# If a value is set it will output to the file.
log_file: /tmp/p11nethsm.log
# Optional log level, acceptable values are Trace, Debug, Info, Warn and Error
log_level: Debug

# Each "slot" represents a HSM cluster of server that share the same user and keys.
slots:
- label: LocalHSM # Name your NetHSM however you want
description: Local HSM (docker) # Optional description

# Users connecting to the NetHSM server
operator:
username: "operator"
# If the password starts with `env:`, it will obtain the password from an environment variable:
# password: "env:LOCALHSMPASS"
password: "localpass"
administrator:
username: "admin"

# List the NetHSM instances
instances:
- url: "https://keyfender:8443/api/v1" # URL to reach the server
# To avoid having to re-open connections on each requests, the module keeps a connection pool to each instance. If the module is used by a multithreaded application, multiple connections can be opened at the same time.
# This configures the maximum number of connections in the pool at the same time.
# Note that this does not limit the total number of open connections.
# Having a degree of parrallelism that is higher than the max number of idle connection can lead overhead as those connections will be closed an re-opened frenquently
max_idle_connections: 10
# By default, the certificate of the HSM will be validated using the system's root certificate authority.
# When the NetHSM uses a self-signed certificate, it can be verified against an allowed list of sha256 fingerprint of the NetHSM's certificate:
sha256_fingerprints:
- "31:92:8E:A4:5E:16:5C:A7:33:44:E8:E9:8E:64:C4:AE:7B:2A:57:E5:77:43:49:F3:69:C9:8F:C4:2F:3A:3B:6E"
# Alternatively certificate checks can be skipped entirely with danger_insecure_cert option.
# This should be avoided if possible and certainly not used with a productive NetHSM.
# danger_insecure_cert: true
# Configure the network retry mechanism. If absent, no retries are attempted on a network error
retries:
# The number of retries after a network error
count: 3
# The delay between retries, in integer seconds
delay_seconds: 1
# Configurable timeout for network operations. If a network operation takes more than, `timeout_seconds`, consider it failed. If `retries` is configured, it will be retried.
# Defaults to infinite
timeout_seconds: 10
3 changes: 3 additions & 0 deletions pkcs11/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -36,3 +36,6 @@ sha2 = { default-features = false, version = "0.10" }
sha1 = { default-features = false, version = "0.10" }
digest = { default-features = false, version = "0.10" }
rayon = "1.8.0"

[dev-dependencies]
hex-literal = "0.4.1"
56 changes: 49 additions & 7 deletions pkcs11/src/config/config_file.rs
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ pub fn read_configuration() -> Result<P11Config, ConfigError> {
merge_configurations(configs)
}

#[derive(Debug, Clone, Serialize, Deserialize)]
#[derive(Debug, Clone, Serialize, Deserialize, PartialEq)]
pub enum LogLevel {
Trace,
Debug,
Expand All @@ -86,7 +86,7 @@ impl From<&LogLevel> for log::LevelFilter {
}

// representation of the config file to parse
#[derive(Debug, Clone, Serialize, Deserialize, Merge, Default)]
#[derive(Debug, Clone, Serialize, Deserialize, Merge, Default, PartialEq)]
pub struct P11Config {
#[merge(strategy = merge::bool::overwrite_false)]
#[serde(default)]
Expand All @@ -97,13 +97,13 @@ pub struct P11Config {
pub slots: Vec<SlotConfig>,
}

#[derive(Debug, Clone, Copy, Serialize, Deserialize)]
#[derive(Debug, Clone, Copy, Serialize, Deserialize, PartialEq)]
pub struct RetryConfig {
pub count: u32,
pub delay_seconds: u64,
}

#[derive(Debug, Clone)]
#[derive(Debug, Clone, PartialEq, Eq)]
pub struct HexFingerprint {
pub value: Vec<u8>,
}
Expand Down Expand Up @@ -148,7 +148,7 @@ impl<'de> Deserialize<'de> for HexFingerprint {
}
}

#[derive(Debug, Clone, Serialize, Deserialize)]
#[derive(Debug, Clone, Serialize, Deserialize, PartialEq)]
pub struct InstanceConfig {
pub url: String,
#[serde(default)]
Expand All @@ -159,7 +159,7 @@ pub struct InstanceConfig {
pub max_idle_connections: Option<usize>,
}

#[derive(Debug, Clone, Serialize, Deserialize)]
#[derive(Debug, Clone, Serialize, Deserialize, PartialEq)]
pub struct SlotConfig {
pub label: String,
pub operator: Option<UserConfig>,
Expand All @@ -173,7 +173,7 @@ pub struct SlotConfig {
}

// An user
#[derive(Debug, Clone, Serialize, Deserialize)]
#[derive(Debug, Clone, Serialize, Deserialize, PartialEq)]
pub struct UserConfig {
pub username: String,
#[serde(deserialize_with = "deserialize_password", default)]
Expand Down Expand Up @@ -205,6 +205,7 @@ where

#[cfg(test)]
mod tests {
use hex_literal::hex;
use std::fs;

use super::*;
Expand Down Expand Up @@ -310,4 +311,45 @@ password: ""
assert_eq!(config.username, "test");
assert_eq!(config.password, None);
}

#[test]
fn test_deserialize_full_example_config() {
let config = include_str!("../../../p11nethsm.example.conf");
assert_eq!(
P11Config {
enable_set_attribute_value: false,
log_file: Some("/tmp/p11nethsm.log".into()),
log_level: Some(LogLevel::Debug),
slots: vec![SlotConfig {
label: "LocalHSM".into(),
description: Some("Local HSM (docker)".into()),
operator: Some(UserConfig {
username: "operator".into(),
password: Some("localpass".into())
}),
administrator: Some(UserConfig {
username: "admin".into(),
password: None
}),
instances: vec![InstanceConfig {
url: "https://keyfender:8443/api/v1".into(),
danger_insecure_cert: false,
sha256_fingerprints: vec![HexFingerprint {
value: hex!(
"31928EA45E165CA73344E8E98E64C4AE7B2A57E5774349F369C98FC42F3A3B6E"
)
.into()
}],
max_idle_connections: Some(10),
}],
retries: Some(RetryConfig {
count: 3,
delay_seconds: 1
}),
timeout_seconds: Some(10),
}]
},
serde_yaml::from_str(config).unwrap()
);
}
}
Loading