Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added reel agent to notebook #55

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

Kaif987
Copy link

@Kaif987 Kaif987 commented Nov 18, 2024

The Reel Agent tutorial demonstrates how to generate addictive video generation like reels in Instagram by using Langchain for script generation, Eleven Labs for text-to-speech, Assembly AI to create subtitles and Moviepy to add speech and subtitles to video

@NirDiamant
Copy link
Owner

the idea is very nice but the notebook isn't written as a tutorial.
please look at the CONTRIBUTING.MD file and edit it accordingly, so I can approve it. thanks!

@Dark-Knight499
Copy link

the idea is very nice but the notebook isn't written as a tutorial. please look at the CONTRIBUTING.MD file and edit it accordingly, so I can approve it. thanks!

Will do it by today

@Dark-Knight499
Copy link

@NirDiamant Here is the updated version

@NirDiamant
Copy link
Owner

that looks much better!
can you please:

  • clear unnecessary cell outputs
  • add a reel demo at the end of the notebook? you can save the reel in the /images folder

@Dark-Knight499
Copy link

that looks much better! can you please:

  • clear unnecessary cell outputs
  • add a reel demo at the end of the notebook? you can save the reel in the /images folder

Added demo reels in the images folder
Added demo reels in the notebook
Cleared unnecessary cell outputs

@NirDiamant
Copy link
Owner

several things:

  • still some noninformative and unnecessary outputs
  • document any non-trivial code and all classes and functions.
  • add a markdown description above each cell with a 3 # font (###)
  • I would suggest passing each function and cell code through an LLM (GPT/Claude/etc) and asking for code refinement
  • remove the youtube link (I will add it on the readme)
  • the resulting reel should be seen on the notebook without the need to manually run it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants