Skip to content
This repository has been archived by the owner on Feb 17, 2025. It is now read-only.

Refactor flake.nix #81

Closed
wants to merge 5 commits into from
Closed

Refactor flake.nix #81

wants to merge 5 commits into from

Conversation

aleasims
Copy link
Contributor

@aleasims aleasims commented Jul 19, 2024

Some refactoring of flake file:

  • Move derivation into separate file, simplify flake file;
  • Removed explicit dev shells from flake file
  • Remove unnecessary step in CI workflow;
  • Remove flake-utils from Crypto3 input (because it's not used in the current revision of Crypto3. However it will have to be added later).

Most of the things work the same as previously. To activate dev debug shell, run:

nix develop .#debug

Some things which may be improved in the future:

  • Refine Boost library propagation properly
  • Refine the list of required Go tools (they were just copy-pasted, probably we don't need all of them)

@aleasims aleasims self-assigned this Jul 19, 2024
@aleasims
Copy link
Contributor Author

aleasims commented Jul 19, 2024

Also created targets in CMake for testing executables (block generator and assigner) runs on example data. To run these tests:

ninja executables_tests

This will compile required binaries (assigner, block_gen, ...) and run them with specified inputs.

These tests are also included into Nix check phase and will be run on:

nix flake check

This will allow us to run all tests inside single derivation via Nix and avoid re-compilation (CI time decreases: ~3min -> ~1.5min).

@aleasims aleasims marked this pull request as ready for review July 19, 2024 14:51
@aleasims aleasims requested review from knazarov and akokoshn July 19, 2024 14:52
@aleasims
Copy link
Contributor Author

@knazarov could you please take a look at Nix part of this PR

Copy link
Member

@x-mass x-mass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except we there is no way to nix develop into debug with tests. Are we sure we don't want to make default check use Debug build? In this case it could be used as a target for nix develop. Or just return back devShells with debug+tests configuration

aleasims and others added 3 commits August 14, 2024 14:28
Move derivation into separate file, simplify flake file.
Remove unnecessary step in CI workflow.
Remove unneccesary CI step, which was causing rebuild of the whole derivation.
ssh scheme will use ssh key instead of username/password for fetching private repo
@akokoshn
Copy link
Collaborator

moved to #84

@akokoshn akokoshn closed this Aug 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants