-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
Also created targets in CMake for testing executables (block generator and assigner) runs on example data. To run these tests:
This will compile required binaries ( These tests are also included into Nix check phase and will be run on:
This will allow us to run all tests inside single derivation via Nix and avoid re-compilation (CI time decreases: ~3min -> ~1.5min). |
@knazarov could you please take a look at Nix part of this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, except we there is no way to nix develop
into debug with tests. Are we sure we don't want to make default check use Debug build? In this case it could be used as a target for nix develop
. Or just return back devShells with debug+tests configuration
Move derivation into separate file, simplify flake file. Remove unnecessary step in CI workflow.
Remove unneccesary CI step, which was causing rebuild of the whole derivation.
ssh scheme will use ssh key instead of username/password for fetching private repo
8ef1dc0
to
2973df0
Compare
moved to #84 |
Some refactoring of flake file:
flake-utils
from Crypto3 input (because it's not used in the current revision of Crypto3. However it will have to be added later).Most of the things work the same as previously. To activate dev debug shell, run:
Some things which may be improved in the future: