This repository has been archived by the owner on Feb 17, 2025. It is now read-only.
Build without hunter #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, take a look at this one: This PR shows how we are going to add Nix here. All submodules will become unnecessary and will be removed. All the dependencies are handled by Nix, so we don't need to fetch anything in CMake, just By the way, Nix does not allow fetching on configuration anyway, so CMakeLists in this PR won't work with Nix at all. |
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing
hunterdependency will help to make evm-assigner build with nix. We still haveevmcsubmodule which useshunterbut it seems that it's possible to build it just with ordinarycmake