This repository has been archived by the owner on Feb 17, 2025. It is now read-only.
add macro for modular_adaptor test #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
closes #62 |
x-mass
approved these changes
May 7, 2024
.github/workflows/pull-request.yml
Outdated
Comment on lines
20
to
22
| uses: NilFoundation/ci-cd/.github/workflows/reusable-handle-syncwith.yml@v1.2.0 | ||
| with: | ||
| ci-cd-ref: 'v1.2.0' |
test/CMakeLists.txt
Outdated
Comment on lines
468
to
473
| set_target_properties(${test_name} PROPERTIES CXX_STANDARD 17) | ||
| if (CMAKE_CXX_COMPILER_ID STREQUAL "Clang") | ||
| target_compile_options(${test_name} PRIVATE "-fconstexpr-steps=2147483647") | ||
| elseif (CMAKE_CXX_COMPILER_ID STREQUAL "GNU") | ||
| target_compile_options(${test_name} PRIVATE "-fconstexpr-ops-limit=4294967295") | ||
| endif() |
There was a problem hiding this comment.
This is already set in define_runtime_multiprecision_test
There was a problem hiding this comment.
good point, thank you
There was a problem hiding this comment.
nit: You moved the set_version.yml, but removed/created all other workflows. Better to keep smaller diff
There was a problem hiding this comment.
is it a big problem? I don't see anything repo-specific in set_version, I guess it is safe to add
test/modular_adaptor_fixed_test.cpp
Outdated
There was a problem hiding this comment.
Aside: I see, that naming as some_name_test.cpp is enforced by CMake define_runtime_multiprecision_test func, let's remove _test postfix someday though. It is obvious there are tests inside test dir
There was a problem hiding this comment.
removed _test suffix
f261741 to
0aa6b68
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.