Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eversense 365 US version companion app #3835

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Eversense 365 US version companion app #3835

merged 1 commit into from
Jan 28, 2025

Conversation

Navid200
Copy link
Collaborator

@Navid200 Navid200 commented Dec 30, 2024 •
edited
Loading

@Navid200
Copy link
Collaborator Author

It doesn't look like the app produces a notification for every reading, only for alerts.

@jamorham
Copy link
Collaborator

So its not worth merging this do you think?

@Navid200
Copy link
Collaborator Author

No, I don't think so.
Unless we consider it a test and remove it later.

@Navid200 Navid200 closed this Jan 18, 2025
@Navid200 Navid200 reopened this Jan 26, 2025
@Navid200
Copy link
Collaborator Author

It seems it works: #677 (comment)

But, it may need improvements. So, please merge.

jamorham
jamorham approved these changes Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@jamorham jamorham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for following this up

@jamorham jamorham merged commit b860d92 into NightscoutFoundation:master Jan 28, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamorham jamorham jamorham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Navid200 @jamorham