Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System Status cleanup #2107

Merged

Conversation

Lupum1001
Copy link
Contributor

Noticed a couple unused files from the old SystemStatus activity and removed them. For example, SystemStatus.java was replaced with SystemStatusFragment.java back in 2017.
I also tweaked some formatting on the System Status page for the sake of readability.

Old
image
New
image

The visual changes are quite subtle, but I didn't want to bundle much else with a file deletion.

…nt appears to have replaced it back in 2017.
…ng before the status values. Patched the cut off text for long Version strings.
Copy link
Collaborator

@jamorham jamorham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me

@tolot27 tolot27 added enhancement ui User interface related code:quality code and repository related labels May 9, 2022
@tolot27
Copy link
Collaborator

tolot27 commented May 9, 2022

Good catch. Looks like you are working on #1522, even if you did not find this issue/task list. 😄

@jamorham jamorham merged commit a88cdbf into NightscoutFoundation:master May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code:quality code and repository related enhancement ui User interface related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants