-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep G6 battery voltage logs for 7 days #1975
Keep G6 battery voltage logs for 7 days #1975
Conversation
Would a |
As long as it is kept for 7 days, I am OK with it. |
I changed it to uel. I am testing it. It will take me a few days to confirm that it really keeps them for 7 days. |
It will definitely kept for seven days because the severity of uel is 5 and everything above 3 will be kept for seven days. |
Why do the values not change even after seven days? That's a bit surprising to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An improvement to the battery monitoring.
Under normal circumstances, the voltages don't change much between days 10 to 90. |
This will keep the G6 battery voltage logs for 7 days instead of just one day.
In simplest ways, it's enough to know what the battery voltage is to judge the health of the battery.
But, there are many factors affecting the recorded voltage. Those include temperature, voltage monitor accuracy, battery production variation, battery production batch, noise at the voltage sample time ...
Keeping the logs for 7 days let's us more confidently judge if the battery is the cause of malfunction or not.
This is what the log looks like now before this PR:
![1](https://user-images.githubusercontent.com/51497406/151859211-e6785389-a84c-4e45-a24a-09e914291e78.png)
This is what the log looks like after this PR:
![3](https://user-images.githubusercontent.com/51497406/151911633-c9421603-2c89-4d98-8c52-08713b58ceeb.png)
So, the log will become teal.
This will be helpful for those who help people use xDrip. Low battery voltage is one of many factors causing malfunction. It (having a 7-day period instead of only 1 day) will be very helpful to confirm that with certainty instead of just a possibility.