Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep G6 battery voltage logs for 7 days #1975

Merged
merged 2 commits into from
Feb 15, 2022

Conversation

Navid200
Copy link
Collaborator

@Navid200 Navid200 commented Jan 31, 2022

This will keep the G6 battery voltage logs for 7 days instead of just one day.

In simplest ways, it's enough to know what the battery voltage is to judge the health of the battery.
But, there are many factors affecting the recorded voltage. Those include temperature, voltage monitor accuracy, battery production variation, battery production batch, noise at the voltage sample time ...

Keeping the logs for 7 days let's us more confidently judge if the battery is the cause of malfunction or not.

This is what the log looks like now before this PR:
1

This is what the log looks like after this PR:
3
So, the log will become teal.

This will be helpful for those who help people use xDrip. Low battery voltage is one of many factors causing malfunction. It (having a 7-day period instead of only 1 day) will be very helpful to confirm that with certainty instead of just a possibility.

@Navid200 Navid200 changed the title Keep battery voltage logs for 7 days Keep G6 battery voltage logs for 7 days Jan 31, 2022
@tolot27
Copy link
Collaborator

tolot27 commented Jan 31, 2022

Would a UserError.Log.uel() be sufficient as well? Its severity is still >3 and the log entry will be retained for seven days.

@Navid200
Copy link
Collaborator Author

As long as it is kept for 7 days, I am OK with it.
But, I checked and alert snooze log is also ueh. I don't know why a snooze alert is more severe than battery voltage. Is it? Does it really matter?

@Navid200
Copy link
Collaborator Author

I changed it to uel. I am testing it. It will take me a few days to confirm that it really keeps them for 7 days.

@tolot27
Copy link
Collaborator

tolot27 commented Jan 31, 2022

It will definitely kept for seven days because the severity of uel is 5 and everything above 3 will be kept for seven days.

@Navid200
Copy link
Collaborator Author

Navid200 commented Feb 9, 2022

This is what it will look like after a search in the logs:
Screenshot_20220209-161715

It will be very useful for users as well as for those helping users.

@tolot27
Copy link
Collaborator

tolot27 commented Feb 9, 2022

This is what it will look like after a search in the logs:

Why do the values not change even after seven days? That's a bit surprising to me.
Nevertheless, it is a good adition.

Copy link
Collaborator

@tolot27 tolot27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An improvement to the battery monitoring.

@tolot27 tolot27 added the next-build PRs to consider for the next build. label Feb 9, 2022
@Navid200
Copy link
Collaborator Author

Under normal circumstances, the voltages don't change much between days 10 to 90.
Thanks

@jamorham jamorham merged commit 8d5082d into NightscoutFoundation:master Feb 15, 2022
@tolot27 tolot27 removed the next-build PRs to consider for the next build. label Feb 15, 2022
@Navid200 Navid200 deleted the Navid_2022_01_29 branch February 18, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants