-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consistent writing and typo fixes of English resource strings #1634
Conversation
Will check the wear strings this evening. Afterwards, I'll remove the draft flag. |
Is the base language en-gb or en-us? I suspect en-gb. |
I've double checked the strings by visual inspection and a word processor. Maybe, it is necessary to adjust the translations as well, especially for 4dfdcfd. |
@jamorham Feel free to cherry-pick any of the commits if you don't want to merge all at once. |
Hi thanks. Can you confirm that you've checked the execution of the positional argument changes to the format strings within the app? They look okay to me but as its effectively a code change I would like confirmation of testing. I believe positional formatting is supported down to the minimum sdk level but I haven't checked that to confirm. |
Renaming of "barcode" is suggested in #1151, too. |
I've tested that the positional arguments work. Argument indices (=positional arguments) are supported since very early Java versions long before Android was developed. |
I don't see invite_follower in the strings file. So, how is the first change (android:text="@string/invite_follower") going to work? |
Commit 1c1b972 contains it. |
This PR addresses many points of #1554