Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consistent writing and typo fixes of English resource strings #1634

Merged
merged 20 commits into from
Apr 24, 2021

Conversation

tolot27
Copy link
Collaborator

@tolot27 tolot27 commented Feb 3, 2021

This PR addresses many points of #1554

@tolot27 tolot27 linked an issue Feb 3, 2021 that may be closed by this pull request
7 tasks
@tolot27 tolot27 added this to the translation milestone Feb 3, 2021
@tolot27 tolot27 marked this pull request as draft February 3, 2021 09:56
@tolot27
Copy link
Collaborator Author

tolot27 commented Feb 3, 2021

Will check the wear strings this evening. Afterwards, I'll remove the draft flag.

@tolot27
Copy link
Collaborator Author

tolot27 commented Feb 3, 2021

Is the base language en-gb or en-us? I suspect en-gb.

@tolot27
Copy link
Collaborator Author

tolot27 commented Feb 4, 2021

I've double checked the strings by visual inspection and a word processor. Maybe, it is necessary to adjust the translations as well, especially for 4dfdcfd.

@tolot27 tolot27 marked this pull request as ready for review February 4, 2021 00:31
@tolot27 tolot27 changed the title consistent writing and typo fixes for English strings consistent writing and typo fixes of English resource strings Feb 4, 2021
@tolot27 tolot27 requested a review from jamorham February 4, 2021 21:09
@tolot27
Copy link
Collaborator Author

tolot27 commented Feb 4, 2021

@jamorham Feel free to cherry-pick any of the commits if you don't want to merge all at once.

@jamorham
Copy link
Collaborator

jamorham commented Feb 5, 2021

Hi thanks. Can you confirm that you've checked the execution of the positional argument changes to the format strings within the app? They look okay to me but as its effectively a code change I would like confirmation of testing. I believe positional formatting is supported down to the minimum sdk level but I haven't checked that to confirm.

@tolot27
Copy link
Collaborator Author

tolot27 commented Apr 13, 2021

Renaming of "barcode" is suggested in #1151, too.

@tolot27
Copy link
Collaborator Author

tolot27 commented Apr 13, 2021

Hi thanks. Can you confirm that you've checked the execution of the positional argument changes to the format strings within the app? They look okay to me but as its effectively a code change I would like confirmation of testing. I believe positional formatting is supported down to the minimum SDK level but I haven't checked that to confirm.

I've tested that the positional arguments work. Argument indices (=positional arguments) are supported since very early Java versions long before Android was developed.

@tolot27 tolot27 added the next-build PRs to consider for the next build. label Apr 13, 2021
@Navid200
Copy link
Collaborator

I don't see invite_follower in the strings file. So, how is the first change (android:text="@string/invite_follower") going to work?

@tolot27
Copy link
Collaborator Author

tolot27 commented Apr 16, 2021

I don't see invite_follower in the strings file. So, how is the first change (android:text="@string/invite_follower") going to work?

Commit 1c1b972 contains it.

@jamorham jamorham merged commit d3bf6f5 into master Apr 24, 2021
@tolot27 tolot27 removed the next-build PRs to consider for the next build. label Apr 25, 2021
@tolot27 tolot27 deleted the strings-en branch June 25, 2021 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

revise source text strings and their translations
3 participants