securing Google Maps key #1596
Merged
securing Google Maps key #1596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 8, 2021
|
rebased on current master (35c786c) |
jamorham
approved these changes
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR can read the Google Maps key from the Gradle project properties or an environment variable.
Rationale: Currently, the Google Maps keys are stored as resource string variables in two files in the debug and release output directory
res/values/google_maps_api.xml, redundantly.Creating a new build type results in a build error until
google_maps_api.xmlis duplicated again. Since the key is identical for all builds, it can be stored centrally.In general, it is a good practice to exclude keys from public repositories. This is not the case with xDrip. With this PR, it is easy to externalize the key from
app/gradle.propertiesand store a newly generated key into an environment variable or a project or local property (local.propertiesfile). It is also possible to set it usinggradle -Pgoogle_maps_key='<key>'or specify it in.travis.ymlin theenvsection, possibly as encrypted variable.