Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create component "Tile" #250

Merged
merged 5 commits into from
Jan 23, 2024
Merged

Create component "Tile" #250

merged 5 commits into from
Jan 23, 2024

Conversation

NicolasOmar
Copy link
Owner

@NicolasOmar NicolasOmar commented Jan 22, 2024

Changes made

  • New component Tile created

My pull request is for

  • A bugfix
  • A new component
  • An existing component update

Also, it complies with the following

  • In case of a new component
    • A folder with its name on src/components/CORRESPONDING_CATEGORY
    • A index.tsx file where the component will be coded
    • New and/or updated interfaces, types, tuples and enums for the component
    • A index.test.ts file for its units tests and create the needed to reach at least 90% of code coverage
    • A index.stories.tsx file for storybook stories and add at least 2 stories for different scenarios

Screenshots

In case of have differences between old and new functionality, please provide a 'Before vs After' comparrison in order to show in a graphic way your contribution

Copy link

netlify bot commented Jan 22, 2024

Deploy Preview for reactivebulma ready!

Name Link
🔨 Latest commit 6ab3119
🔍 Latest deploy log https://app.netlify.com/sites/reactivebulma/deploys/65affc6b318f720007e0255d
😎 Deploy Preview https://deploy-preview-250--reactivebulma.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (a07e60d) 100.00% compared to head (6ab3119) 99.89%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/components/organisms/TileGroup/index.tsx 94.11% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main     #250      +/-   ##
===========================================
- Coverage   100.00%   99.89%   -0.11%     
===========================================
  Files           44       47       +3     
  Lines          939      987      +48     
  Branches       665      700      +35     
===========================================
+ Hits           939      986      +47     
- Misses           0        1       +1     
Flag Coverage Δ
unittests 99.89% <97.95%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NicolasOmar NicolasOmar linked an issue Jan 23, 2024 that may be closed by this pull request
5 tasks
Copy link

@NicolasOmar NicolasOmar marked this pull request as ready for review January 23, 2024 17:56
@NicolasOmar NicolasOmar merged commit f5877ac into main Jan 23, 2024
10 of 12 checks passed
@NicolasOmar NicolasOmar deleted the component/tile branch January 23, 2024 17:56
github-actions bot pushed a commit that referenced this pull request Jan 23, 2024
# [2.15.0](v2.14.0...v2.15.0) (2024-1-23)

### Bug Fixes

* Moving componentEnums content to domTypes for better type management ([80ef7eb](80ef7eb))

### Features

* Create component "Tile" ([#250](#250)) ([#74](#74)) ([f5877ac](f5877ac))
Copy link

🎉 This PR is included in version 2.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create component "Tile"
1 participant