Create component "Hero" #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
5 tasks
✅ Deploy Preview for reactivebulma ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #249 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 43 44 +1
Lines 923 939 +16
Branches 652 665 +13
=========================================
+ Hits 923 939 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
github-actions bot
pushed a commit
that referenced
this pull request
Jan 22, 2024
# [2.14.0](v2.13.0...v2.14.0) (2024-1-22) ### Bug Fixes * Creating ChildrenType and SingleChildType less redudant types ([864ae47](864ae47)) * Small renames on used Types for better naming consistency ([70638f8](70638f8)) ### Features * Create component "Hero" ([#249](#249)) ([#72](#72)) ([a07e60d](a07e60d))
|
🎉 This PR is included in version 2.14.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made
Explain what you made to present the following solution on this pull request.
My pull request is for
Also, it complies with the following
new componentsrc/components/organismsindex.tsxfile where the component will be codedindex.test.tsfile for its units tests and create the needed to reach at least 90% of code coverageindex.stories.tsxfile for storybook stories and add at least 2 stories for different scenariosScreenshots
In case of have differences between old and new functionality, please provide a 'Before vs After' comparrison in order to show in a graphic way your contribution