Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select cannot handle user interactions #529

Closed
NicolasOmar opened this issue Dec 26, 2024 · 0 comments · Fixed by #530
Closed

Select cannot handle user interactions #529

NicolasOmar opened this issue Dec 26, 2024 · 0 comments · Fixed by #530
Assignees
@NicolasOmar
Labels
bug Something isn't working research Investigation about tech, methodology or other
Milestone
v5.0.0

Comments

@NicolasOmar
Copy link
Owner

Description

The Select component lacks functional user interaction-based behaviors such as onChange, onBlur, and onClick.

Steps to reproduce

Steps to reproduce the behavior:

  1. Import a Select component in your project.
  2. Add an onChange, onBlur, or onClick handle method.
  3. Use the mentioned component locally.

Expected behavior

The method used worked as expected.

Additional context

N/A.

Technical notes

The component should implement the recommended logic according to React site.
@NicolasOmar NicolasOmar added bug Something isn't working research Investigation about tech, methodology or other labels Dec 26, 2024
@NicolasOmar NicolasOmar self-assigned this Dec 26, 2024
@NicolasOmar NicolasOmar added this to the v5.0.0 milestone Dec 26, 2024
@NicolasOmar NicolasOmar linked a pull request Dec 26, 2024 that will close this issue
Add missing interactions in Select component #530
Merged
6 tasks
NicolasOmar added a commit that referenced this issue Dec 27, 2024
@NicolasOmar
fix: Fixing non-functional user interactions in Select component (#530)…
40e2010 
… (#529)

### Changes made 
- Moved all user interaction-related methods up to the `select` tag.
- Added `isDisabled` and `selectedValues` properties:
  - `isDisabled` was missing in former versions.
- `selectedValues` will replace the former logic in the `option` tag and
now in the `select` tag.

---

### My pull request is for
- [x] A bugfix
- [ ] A new component
- [x] An existing component update
- [ ] Dependencies version update

- In case of a `bug` or an `existing component update`
  - [x] Updated unit tests that reach at least 90% of code coverage.
- [x] Updated interfaces, types, tuples, and enums for the impacted
component/s

---

### Screenshots
N/A
@github-project-automation github-project-automation bot moved this from In Progress to Done in Reactive-bulma | Project board Dec 27, 2024
github-actions bot pushed a commit that referenced this issue Dec 27, 2024
@semantic-release-bot
chore(release): 4.3.3 [skip ci]
033fb7d 
## [4.3.3](v4.3.2...v4.3.3) (2024-12-27)

### Bug Fixes

* Fixing non-functional user interactions in Select component ([#530](#530)) ([#529](#529)) ([40e2010](40e2010))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NicolasOmar NicolasOmar

Labels
bug Something isn't working research Investigation about tech, methodology or other
Projects
Reactive-bulma | Project board
Status: Done
Milestone
v5.0.0
Development

Successfully merging a pull request may close this issue.

Add missing interactions in Select component NicolasOmar/reactive-bulma
1 participant
@NicolasOmar