Skip to content

Commit

Permalink
chore: update the result of CR (gin-gonic#2354)
Browse files Browse the repository at this point in the history
* chore: update the result of CR

* Update utils.go

* Update utils.go

* Update context.go

* Update context.go
  • Loading branch information
thinkerou authored May 4, 2020
1 parent abc4fa0 commit 54175db
Show file tree
Hide file tree
Showing 6 changed files with 16 additions and 10 deletions.
5 changes: 3 additions & 2 deletions auth.go
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,9 @@ func BasicAuth(accounts Accounts) HandlerFunc {
}

func processAccounts(accounts Accounts) authPairs {
assert1(len(accounts) > 0, "Empty list of authorized credentials")
pairs := make(authPairs, 0, len(accounts))
length := len(accounts)
assert1(length > 0, "Empty list of authorized credentials")
pairs := make(authPairs, 0, length)
for user, password := range accounts {
assert1(user != "", "User can not be empty")
value := authorizationHeader(user, password)
Expand Down
4 changes: 3 additions & 1 deletion context.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,11 @@ const (
MIMEPOSTForm = binding.MIMEPOSTForm
MIMEMultipartPOSTForm = binding.MIMEMultipartPOSTForm
MIMEYAML = binding.MIMEYAML
BodyBytesKey = "_gin-gonic/gin/bodybyteskey"
)

// BodyBytesKey indicates a default body bytes key.
const BodyBytesKey = "_gin-gonic/gin/bodybyteskey"

const abortIndex int8 = math.MaxInt8 / 2

// Context is the most important part of gin. It allows us to pass variables between middleware,
Expand Down
7 changes: 4 additions & 3 deletions gin.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,12 @@ import (
const defaultMultipartMemory = 32 << 20 // 32 MB

var (
default404Body = []byte("404 page not found")
default405Body = []byte("405 method not allowed")
defaultAppEngine bool
default404Body = []byte("404 page not found")
default405Body = []byte("405 method not allowed")
)

var defaultAppEngine bool

// HandlerFunc defines the handler used by gin middleware as return value.
type HandlerFunc func(*Context)

Expand Down
1 change: 1 addition & 0 deletions mode.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ const (
// TestMode indicates gin mode is test.
TestMode = "test"
)

const (
debugCode = iota
releaseCode
Expand Down
7 changes: 4 additions & 3 deletions path.go
Original file line number Diff line number Diff line change
Expand Up @@ -136,10 +136,11 @@ func bufApp(buf *[]byte, s string, w int, c byte) {

// Otherwise use either the stack buffer, if it is large enough, or
// allocate a new buffer on the heap, and copy all previous characters.
if l := len(s); l > cap(b) {
*buf = make([]byte, len(s))
length := len(s)
if length > cap(b) {
*buf = make([]byte, length)
} else {
*buf = (*buf)[:l]
*buf = (*buf)[:length]
}
b = *buf

Expand Down
2 changes: 1 addition & 1 deletion recovery.go
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,6 @@ func function(pc uintptr) []byte {
}

func timeFormat(t time.Time) string {
var timeString = t.Format("2006/01/02 - 15:04:05")
timeString := t.Format("2006/01/02 - 15:04:05")
return timeString
}

0 comments on commit 54175db

Please sign in to comment.