Add deconstruction to FileTreeNode for cleaner tests #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated FileTreeNode class to include Deconstruct method, enabling more readable testing of path and value. Changes have been applied to both Absolute and Relative FileTreeTests. Deconstruction simplifies asserting equalities and improves overall code readability in tests.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #13 +/- ##
==========================================
+ Coverage 77.28% 77.33% +0.05%
==========================================
Files 35 35
Lines 1743 1747 +4
Branches 298 298
==========================================
+ Hits 1347 1351 +4
Misses 340 340
Partials 56 56
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Al12rs
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated FileTreeNode class to include Deconstruct method, enabling more readable testing of path and value. Changes have been applied to both Absolute and Relative FileTreeTests. Deconstruction simplifies asserting equalities and improves overall code readability in tests.