Pass revision directly #2756
Merged
Pass revision directly #2756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doesn't do a lookup, fixes Nexus-Mods#2749.
Al12rs
approved these changes
Feb 27, 2025
|
Didn't test, but the code should do as advertised |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't do a lookup anymore and just passes the revision directly, fixes #2749.
The bug was caused because we'd observe all revisions and create cards out of them, the cards constructor would get passed an ID and do a lookup for the revision using LINQ
First()which throws an exception if there are no items in the source enumerable. This can happen if the collection gets deleted, which sends the user to the library and then there's probably a race condition where the revision gets deleted while we try to create the collection card.With this PR we won't get an exception, the card will disappear immediately.