Added: Miscellaneous Bug Fixes around Updates #2742

Sewer56 · 2025-02-26T19:36:29Z

Basically what I got done today, and a bit of yesterday.
Fixes the reported bugs around updating, and adds a bunch of tests around the functionality; to ensure it never breaks again.

…update when latest installed. I had something much more elaborate here originally, where you could also carry on the other versions and have a dropdown, but stripped it down for this commit. fixes #2712 fixes #2711

fixes #2711

Upon deletion of a newer version.

src/Networking/NexusMods.Networking.NexusWebApi/ModUpdateService.cs

…sion. fixes #2747

I think I'll change this to update at download time though. This makes adding collections a bit too slow.

Sewer56 added 7 commits February 26, 2025 09:47

Fixed: Updating items on one mod page hides updates on another mod page.

e6a1cca

fixes #2711

Added: Basic Update Checker Tests

5a0f4cd

Added: Basic tests around receiving update notification events.

07118ae

Added: Test for cross mod-page mod update notifications

03b80e6

Fixed: Reused state between ModUpdateServiceTests runs.

af6c499

Added: Test that ensures older versions receive updates automatically.

ed5a03c

Upon deletion of a newer version.

Sewer56 requested a review from a team February 26, 2025 19:36

Sewer56 self-assigned this Feb 26, 2025

Sewer56 added 5 commits February 26, 2025 19:37

Style: Internal goes before private.

5d86290

Removed: Accidental whitespace inclusion.

f1fb236

Added: Additional XML documentation around the new functions.

1366416

Removed: Redundant single comment.

a800b3d

Removed: Unintended whitespace (via GitHub diff)

da1fbbc

Sewer56 marked this pull request as ready for review February 26, 2025 19:44

Merge remote-tracking branch 'origin/main' into fix-updates-order

494add4

Al12rs self-requested a review February 27, 2025 09:15

Al12rs reviewed Feb 27, 2025

View reviewed changes

src/Networking/NexusMods.Networking.NexusWebApi/ModUpdateService.cs Outdated Show resolved Hide resolved

Sewer56 added 2 commits February 27, 2025 09:54

Fixed: When an update is available, old version now shows correct ver…

c0ac158

…sion. fixes #2747

Style: Update _lastUpdateCheckTime outside of branch.

b067059

Sewer56 force-pushed the fix-updates-order branch from 9242ee4 to b067059 Compare February 27, 2025 09:57

Sewer56 added 3 commits February 27, 2025 13:50

Added: Update all mod pages upon adding collection.

3f83845

I think I'll change this to update at download time though. This makes adding collections a bit too slow.

Changed: Revert calling ResolveAllFilesInModPage

722d023

Changed: Collection Download no Longer Sets Files Updated Timestamp

52722d0

Sewer56 force-pushed the fix-updates-order branch from c4455b5 to 52722d0 Compare February 27, 2025 14:30

Sewer56 added 3 commits February 27, 2025 14:49

Fixed: Default timestamp should be MinValue not UtcNow

7d46ebe

Fixed: Mod update button not correctly updating [thanks @erri120]

80beac4

Merge remote-tracking branch 'origin/main' into fix-updates-order

29671eb

Al12rs approved these changes Feb 27, 2025

View reviewed changes

Al12rs merged commit 1e52766 into main Feb 27, 2025
12 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added: Miscellaneous Bug Fixes around Updates #2742

Added: Miscellaneous Bug Fixes around Updates #2742

Sewer56 commented Feb 26, 2025 •

edited

Loading

Added: Miscellaneous Bug Fixes around Updates #2742

Added: Miscellaneous Bug Fixes around Updates #2742

Conversation

Sewer56 commented Feb 26, 2025 • edited Loading

Sewer56 commented Feb 26, 2025 •

edited

Loading