Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cli fixes and escape hatches #2457

Merged
merged 6 commits into from
Jan 9, 2025
Merged

Cli fixes and escape hatches #2457

merged 6 commits into from
Jan 9, 2025

Conversation

halgari
Copy link
Collaborator

@halgari halgari commented Jan 9, 2025

This PR does the following

  • Fixes consoles on Windows
    • When compiling with WinExe the console isn't connected
    • When compiling with Exe we always get a console, even when running in UI mode
    • This is a windows issue. Fixed by compiling with WinExe mode and doing some P/Invoke magic to attach any existing consoles
  • Changes up the Proxy Console code a bit so we can create paths of modules for verbs instead of prefixing verbs. For example instead of nexus-login we can have nexus login, nexus verify etc. This is opt-in and we can convert verbs over as time goes on.
  • Modules (verb prefixes) can have doc strings so we can do nexus --help to find out what console commands are available in that module
  • Verb options can now be optional
  • Verb options that are not optional are now always required
  • Reorganized/Cleaned up the loadout management verbs
  • Added some new render helpers, so we can do code like (IEnumerable<(string, int)>).RenderTable(renderer, "Name", "Count"); making a lot of the render code easier to read
  • Added some exception catching to the verb dispatch code
  • Added a way to delete files based on a file glob from specific mods via the CLI. So now we have an escape hatch for files that get stuck in Overrides.

@halgari halgari requested a review from a team January 9, 2025 00:03
@halgari halgari marked this pull request as ready for review January 9, 2025 01:20
@Al12rs
Copy link
Contributor

Al12rs commented Jan 9, 2025

Just checked the failing tests, it seems they need to be updated to use the new CLI incantations

@github-actions github-actions bot added the status-needs-rebase Set by CI do not remove label Jan 9, 2025
Copy link
Contributor

github-actions bot commented Jan 9, 2025

This PR conflicts with main. You need to rebase the PR before it can be merged.

@github-actions github-actions bot removed the status-needs-rebase Set by CI do not remove label Jan 9, 2025
Copy link
Contributor

github-actions bot commented Jan 9, 2025

This PR doesn't conflict with main anymore. It can be merged after all status checks have passed and it has been reviewed.

@halgari halgari merged commit 24847f3 into main Jan 9, 2025
12 checks passed
@erri120 erri120 deleted the cli-fixes-and-hatches branch February 25, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants