Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(windows-build): fix symlink error on Windows + CI not working for Windows #101

Merged
merged 9 commits into from
Feb 18, 2025

Conversation

Thyodas
Copy link
Member

@Thyodas Thyodas commented Feb 18, 2025

This pull request includes several updates and improvements to the build configuration, documentation, and test setup for the NEXO Engine for Windows.

Changes

  • Added a troubleshooting documentation in docs/troubleshooting/troubleshooting.md
    This will help users solve many problems for compilation and running our engine.
  • Added MESA installation on Windows, before this tests for Windows weren't really running and were just skipped.
  • Added safeguard condition in the gtest main to check if any test at least ran, before the CI was passing while no tests were tried.
  • Platform specific symlink configuration, previously build errors happened on some Windows systems, now it only shows a warning.

@Thyodas Thyodas added the bug Something isn't working label Feb 18, 2025
@Thyodas Thyodas requested review from iMeaNz and Copilot February 18, 2025 21:41
@Thyodas Thyodas self-assigned this Feb 18, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 19 changed files in this pull request and generated 3 comments.

Files not reviewed (16)
  • CMakeLists.txt: Language not supported
  • examples/CMakeLists.txt: Language not supported
  • scripts/install.cmake: Language not supported
  • scripts/linux/deb_config.cmake: Language not supported
  • scripts/windows/check_dev_mode.cmake: Language not supported
  • src/game_engine/ecs/CMakeLists.txt: Language not supported
  • tests/CMakeLists.txt: Language not supported
  • tests/common/CMakeLists.txt: Language not supported
  • tests/ecs/CMakeLists.txt: Language not supported
  • tests/engine/CMakeLists.txt: Language not supported
  • tests/engine/layer/LayerStack.test.cpp: Language not supported
  • tests/engine/scene/Scene.test.cpp: Language not supported
  • tests/engine/scene/SceneManager.test.cpp: Language not supported
  • tests/renderer/CMakeLists.txt: Language not supported
  • tests/renderer/Framebuffer.test.cpp: Language not supported
  • tests/test_main.cpp: Language not supported

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@Thyodas Thyodas merged commit f95a8e7 into dev Feb 18, 2025
8 checks passed
@Thyodas Thyodas deleted the fix/windows-build branch February 18, 2025 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

fix(windows): cannot create symbolic link : A required privilege is not held by the client.
1 participant