Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 11.0.2 API Deprecations #24

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix 11.0.2 API Deprecations #24

wants to merge 2 commits into from

Conversation

Rycia
Copy link
Collaborator

@Rycia Rycia commented Aug 15, 2024

No description provided.

@Rycia Rycia requested a review from Nevcairiel August 15, 2024 23:40
@Nevcairiel
Copy link
Owner

None of these changes are necessary, or correct, unfortunately.

  • GetSpellName is already handled by an upvalue that selects the correct function on all relevant clients (C_Spell is not available on classic)
  • C_AddOns.GetAddOnEnableState swapped the arguments to have the addon name first, and character second, like the current code
    Are you actually seeing any problems?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nevcairiel Nevcairiel Awaiting requested review from Nevcairiel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rycia @Nevcairiel