Improve show for Connector objects
#503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f individual connections
…o avoid accumulating them again
david-hofmann
pushed a commit
that referenced
this pull request
Jan 2, 2025
* use `Vector{Vector}` and `Dict` in `Connector` fields to keep track of individual connections
* import `MTK.equations`
* improve `show` for `Connector`
* add getter functions for all `Connector` fields
* add `Vector{Vector}` wrapper function
* remove old `BloxConnector` getter functions
* change local variable name to not clash with getter function name
* add `equations(Connector)` argument to discrete callback generators to avoid accumulating them again
* adapt `AdjacencyMatrix` to new `Connector` field types
david-hofmann
pushed a commit
that referenced
this pull request
Jan 3, 2025
* use `Vector{Vector}` and `Dict` in `Connector` fields to keep track of individual connections
* import `MTK.equations`
* improve `show` for `Connector`
* add getter functions for all `Connector` fields
* add `Vector{Vector}` wrapper function
* remove old `BloxConnector` getter functions
* change local variable name to not clash with getter function name
* add `equations(Connector)` argument to discrete callback generators to avoid accumulating them again
* adapt `AdjacencyMatrix` to new `Connector` field types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes how
Connectorobjects are shown for user friendliness.The
Connectorfields are nowVector{Vector{...}}to keep track of the fields of individual connections while being also able to reduce over them for the final system.spike_affectsandlearning_ruleare stillDicts since their keys are otherConnectorfields, so accessing connection-specific affects and plasticity rules is easy.