Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firing rate cleaning #496

Merged
merged 5 commits into from
Dec 6, 2024
Merged

Firing rate cleaning #496

merged 5 commits into from
Dec 6, 2024

Conversation

gabrevaya
Copy link
Contributor

  • Fix firing rate win_size when using transient ≠ 0
  • Update scripts and tests using mean_firing_rate
  • Remove mean_firing_rate function
  • Add a firing_rate dispatch for EnsembleSolution

- remove `mean_firing_rate` function
- add a `firing_rate` dispatch for `EnsembleSolution`
Copy link
Member

@harisorgn harisorgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gabrevaya gabrevaya merged commit 0a1f61d into master Dec 6, 2024
6 checks passed
@gabrevaya gabrevaya deleted the firing_rate_cleaning branch December 6, 2024 13:22
david-hofmann pushed a commit that referenced this pull request Jan 2, 2025
* fix `win_size` when using `transient` ≠ 0
* update scripts and tests using `mean_firing_rate`
* remove `mean_firing_rate` function
* add a `firing_rate` dispatch for `EnsembleSolution`
* change in a comment for consistency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants