Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excluded some old code/non-relevant code from coverage. #143

Merged
merged 1 commit into from
Mar 16, 2018

Conversation

mdenker
Copy link
Member

@mdenker mdenker commented Mar 14, 2018

Some functions in statistics,py are deprecated and should not contribute to coverage (will be removed soon).

The file make_spiketrain_extraction_test_data is only contained for reference to indicate how the fixed test data for the spike_train_extraction_module was generated originally, and should also not be covered.

@mdenker mdenker added the enhancement Editing an existing module, improving something label Mar 14, 2018
@coveralls
Copy link
Collaborator

coveralls commented Mar 14, 2018

Coverage Status

Coverage increased (+1.2%) to 86.991% when pulling 27f588d on INM-6:fix/oldcodecover into 08d6ff1 on NeuralEnsemble:master.

@alperyeg
Copy link
Contributor

@mdenker I will merge this PR, but can you make an issue to remind us to remove the old parts later on, e.g. for the next release (v0.5).

@alperyeg alperyeg merged commit 686dd26 into NeuralEnsemble:master Mar 16, 2018
@alperyeg alperyeg deleted the fix/oldcodecover branch March 29, 2018 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Editing an existing module, improving something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants