Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shutter: p2p logging #7735

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Shutter: p2p logging #7735

merged 1 commit into from
Nov 6, 2024

Conversation

Marchhill
Copy link
Contributor

Changes

  • Enable libp2p logging from config for easier debugging

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Documentation

Requires documentation update

  • Yes
  • No

Requires explanation in Release Notes

  • Yes
  • No

@Marchhill Marchhill requested a review from rubo as a code owner November 6, 2024 15:26
@Marchhill Marchhill requested review from flcl42 and ak88 November 6, 2024 15:26
@Marchhill Marchhill merged commit 5f8369a into master Nov 6, 2024
77 checks passed
@Marchhill Marchhill deleted the feature/shutter-p2p-logs branch November 6, 2024 15:32
@flcl42
Copy link
Contributor

flcl42 commented Nov 6, 2024

It's done not in canonical way I guess, but will simplify a lot debugging related issues

@Marchhill
Copy link
Contributor Author

It's done not in canonical way I guess, but will simplify a lot debugging related issues

What would be the canonical way?

@flcl42
Copy link
Contributor

flcl42 commented Nov 6, 2024

We can log all as is and set filtering in config to display only what we need, but I doubt it's easy to describe to users

@Marchhill
Copy link
Contributor Author

We can log all as is and set filtering in config to display only what we need, but I doubt it's easy to describe to users

I wouldn't expect any users to enable this so I hid in docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants