Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ArrayPool for Discovery Deserialization #7427

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Use ArrayPool for Discovery Deserialization #7427

merged 2 commits into from
Sep 13, 2024

Conversation

benaadams
Copy link
Member

Changes

  • Alas need to use ArraySegment<byte> rather than Span<byte> as the DotNetty types don't accept Span

Mild allocation

image

Types of changes

What types of changes does your code introduce?

  • Optimization

Testing

Requires testing

  • No

LukaszRozmej
LukaszRozmej reviewed Sep 13, 2024
View reviewed changes
Copy link
Member

@LukaszRozmej LukaszRozmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move to ArrayPoolList (add something to it if needed), we don't need more types.

src/Nethermind/Nethermind.Core/Buffers/ArrayPoolDisposableReturn.cs Show resolved Hide resolved
@benaadams benaadams merged commit c5e5d4a into master Sep 13, 2024
66 checks passed
@benaadams benaadams deleted the discovery-message branch September 13, 2024 07:40
deffrian pushed a commit that referenced this pull request Oct 28, 2024
@benaadams @deffrian
Use ArrayPool for Discovery Deserialization (#7427)
a9d2cbe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benaadams @LukaszRozmej