Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fast address equals #7417

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Fast address equals #7417

merged 1 commit into from
Sep 11, 2024

Conversation

benaadams
Copy link
Member

Changes

  • Address is always 20 bytes so can do direct Vector128 + uint compare rather than calling SequenceEqual

Types of changes

What types of changes does your code introduce?

  • Optimization

Testing

Requires testing

  • No

@benaadams benaadams merged commit 1199203 into master Sep 11, 2024
66 checks passed
@benaadams benaadams deleted the address-equals branch September 11, 2024 18:19
rjnrohit pushed a commit that referenced this pull request Sep 12, 2024
@benaadams @rjnrohit
Fast address equals (#7417)
4a17264
deffrian pushed a commit that referenced this pull request Oct 28, 2024
@benaadams @deffrian
Fast address equals (#7417)
1d1f200
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

Assignees
No one assigned
Labels
performance is good
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benaadams @LukaszRozmej