Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/make pre warmer worldstate agnostic #7109

Merged
merged 7 commits into from
Jun 10, 2024
Merged

Refactor/make pre warmer worldstate agnostic #7109

merged 7 commits into from
Jun 10, 2024

Conversation

asdacap
Copy link
Contributor

@asdacap asdacap commented May 30, 2024

  • Make pre block warmer world state type agnostic.

Types of changes

  • Refactoring

LukaszRozmej
LukaszRozmej reviewed May 30, 2024
View reviewed changes
Copy link
Member

@LukaszRozmej LukaszRozmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have mixed feelings, we are bloating IWorldState and kind of hide a bit the intention of the hashes.

@asdacap
Copy link
Contributor Author

asdacap commented May 30, 2024

We should hide it. A different state db might not even have rlp encoding at all.

@asdacap asdacap merged commit 424d6f3 into master Jun 10, 2024
68 checks passed
@asdacap asdacap deleted the refactor/make-pre-warmer-worldstate-agnostic branch June 10, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asdacap @LukaszRozmej