Skip to content
This repository has been archived by the owner on Dec 12, 2023. It is now read-only.

Improve backup ls command #86

Merged
merged 5 commits into from
Oct 4, 2023
Merged

Improve backup ls command #86

merged 5 commits into from
Oct 4, 2023

Conversation

adriantpaez
Copy link
Contributor

Changes:

  • Show more information to backup ls command
    • ID: a unique identifier for a backup. The ID is calculated with SHA1(<instance-id>-<timestamp-unix>-<version>-<commit>)
    • Version: version of the AVS
    • Commit: commit of the AVS
    • URL: url of the AVS repository
  • Get the backup information from the data/state.json file inside the backup tar file

Types of changes

  • New feature (non-breaking change which adds functionality)

Testing

Requires testing Yes

In case you checked yes, did you write tests? Yes

@adriantpaez adriantpaez self-assigned this Oct 4, 2023
@adriantpaez adriantpaez requested a review from AntiD2ta as a code owner October 4, 2023 08:01
@adriantpaez adriantpaez marked this pull request as draft October 4, 2023 08:22
@adriantpaez adriantpaez marked this pull request as ready for review October 4, 2023 09:44
AntiD2ta
AntiD2ta suggested changes Oct 4, 2023
View reviewed changes
Copy link
Member

@AntiD2ta AntiD2ta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good refactor. Missing some tests

internal/utils/tar.go Show resolved Hide resolved
@AntiD2ta AntiD2ta merged commit a417ead into develop Oct 4, 2023
@AntiD2ta AntiD2ta deleted the feat/backup-ls branch October 4, 2023 14:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AntiD2ta AntiD2ta AntiD2ta approved these changes

Assignees

@adriantpaez adriantpaez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adriantpaez @AntiD2ta