Skip to content
This repository has been archived by the owner on Dec 12, 2023. It is now read-only.

Backup #81

Merged
merged 23 commits into from
Oct 3, 2023
Merged

Backup #81

merged 23 commits into from
Oct 3, 2023

Conversation

adriantpaez
Copy link
Contributor

@adriantpaez adriantpaez commented Sep 27, 2023 •
edited
Loading

Add backup feature

Changes:

  • Add backup command
  • Add backup ls command
  • Add .tar uitl functions
  • Support new options for docker run
  • Fix instance locker initialization
  • Add BuildImageFromURI supporting build images from remote context
  • Get compose project from an instance

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Testing

Requires testing Yes

In case you checked yes, did you write tests? Yes (WIP)

@adriantpaez adriantpaez self-assigned this Sep 27, 2023
@adriantpaez adriantpaez force-pushed the feat/backup branch 3 times, most recently from 70d42e5 to fd6078a Compare September 27, 2023 17:13
AntiD2ta
AntiD2ta suggested changes Sep 28, 2023
View reviewed changes
cli/backup.go Outdated Show resolved Hide resolved
cli/backup.go Show resolved Hide resolved
cli/backup_ls.go Outdated Show resolved Hide resolved
cli/backup_ls.go Show resolved Hide resolved
cli/backup_ls.go Outdated Show resolved Hide resolved
internal/docker/docker_test.go Outdated Show resolved Hide resolved
internal/backup/manager.go Outdated Show resolved Hide resolved
pkg/daemon/backup.go Outdated Show resolved Hide resolved
internal/utils/tar.go Outdated Show resolved Hide resolved
internal/utils/tar.go Show resolved Hide resolved
@adriantpaez adriantpaez force-pushed the feat/backup branch 2 times, most recently from 4ac9272 to 9ae755d Compare September 28, 2023 11:35
@adriantpaez adriantpaez marked this pull request as ready for review October 3, 2023 06:45
AntiD2ta
AntiD2ta suggested changes Oct 3, 2023
View reviewed changes
Copy link
Member

@AntiD2ta AntiD2ta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last review done. It was about missing tests.

internal/backup/manager.go Show resolved Hide resolved
internal/data/backup.go Outdated Show resolved Hide resolved
@AntiD2ta AntiD2ta merged commit 914ece0 into develop Oct 3, 2023
@AntiD2ta AntiD2ta deleted the feat/backup branch October 3, 2023 16:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AntiD2ta AntiD2ta AntiD2ta approved these changes

Assignees

@adriantpaez adriantpaez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adriantpaez @AntiD2ta