This repository has been archived by the owner on Dec 12, 2023. It is now read-only.
Update mock avs links #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriantpaez
reviewed
Sep 13, 2023
There was a problem hiding this comment.
I noticed that some test cases use const variables for the repo URL and version, while others do not. Do you think this is something we should enforce in all tests? If so, we could create an internal/mock_avs package that contains all the const values related to the mock-avs and mock-avs-pkg repositories for easy access in the tests
|
I really like this new package for the mock-avs version management, nice! |
adriantpaez
approved these changes
Sep 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
manifest.namefor Instance ID.Types of changes
Leave on the following list the types of changes introduced by this PR and remove
the ones that don't apply. Please also remove this line.
Testing
Requires testing Yes
In case you checked yes, did you write tests? Yes