Skip to content
This repository has been archived by the owner on Dec 12, 2023. It is now read-only.

Remove build context #61

Merged
merged 5 commits into from
Aug 30, 2023
Merged

Remove build context #61

merged 5 commits into from
Aug 30, 2023

Conversation

adriantpaez
Copy link
Contributor

@adriantpaez adriantpaez commented Aug 28, 2023 •
edited
Loading

Changes:

  • Stop supporting the build option for AVS docker compose services
  • Remove build_from fro plugin image

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Testing

Requires testing Yes

In case you checked yes, did you write tests? No (WIP)

@adriantpaez adriantpaez self-assigned this Aug 28, 2023
@adriantpaez adriantpaez force-pushed the feat/remove-build-context branch 4 times, most recently from c6e0530 to 43108bc Compare August 29, 2023 13:45
@adriantpaez adriantpaez marked this pull request as ready for review August 29, 2023 13:58
@adriantpaez adriantpaez requested a review from AntiD2ta as a code owner August 29, 2023 13:58
AntiD2ta
AntiD2ta suggested changes Aug 29, 2023
View reviewed changes
Copy link
Member

@AntiD2ta AntiD2ta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the README.md with the new changes.

internal/package_handler/package.go Show resolved Hide resolved
internal/package_handler/package_test.go Outdated Show resolved Hide resolved
@adriantpaez
Copy link
Contributor Author

Please update the README.md with the new changes.

Done 110b675

@adriantpaez adriantpaez mentioned this pull request Aug 29, 2023
Merged
@adriantpaez adriantpaez force-pushed the feat/remove-build-context branch from fb6a7d2 to f358b26 Compare August 30, 2023 09:20
@AntiD2ta AntiD2ta merged commit 206bad3 into develop Aug 30, 2023
@AntiD2ta AntiD2ta deleted the feat/remove-build-context branch August 30, 2023 09:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AntiD2ta AntiD2ta AntiD2ta approved these changes

Assignees

@adriantpaez adriantpaez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adriantpaez @AntiD2ta