Skip to content
This repository has been archived by the owner on Dec 12, 2023. It is now read-only.

add keys relative to home folder #118

Merged
merged 4 commits into from
Oct 17, 2023
Merged

Conversation

shrimalmadhur
Copy link
Collaborator

Fixes | Closes | Resolves #

#109

Changes:

  • Create/Import/List keys relative to home folder

Types of changes

Leave on the following list the types of changes introduced by this PR and remove
the ones that don't apply. Please also remove this line.

  • New feature (non-breaking change which adds functionality)

Testing

Requires testing Yes/No

In case you checked yes, did you write tests? Yes/No

Comments about testing , should you have some (optional)

Further comments (optional)

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

AntiD2ta

This comment was marked as outdated.

Copy link
Member

@AntiD2ta AntiD2ta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the changelog. The rest LGTM

cli/operator/keys/import_test.go Outdated Show resolved Hide resolved
cli/operator/keys/import_test.go Outdated Show resolved Hide resolved
cli/operator/keys/import_test.go Outdated Show resolved Hide resolved
cli/operator/keys/create.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@samlaf samlaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shrimalmadhur shrimalmadhur dismissed AntiD2ta’s stale review October 17, 2023 20:18

Added change log and got another approval.

@shrimalmadhur shrimalmadhur merged commit 4120c99 into develop Oct 17, 2023
1 check passed
@shrimalmadhur shrimalmadhur deleted the madhur/create-keys-home branch October 17, 2023 20:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eigenlayer operator keys create to use directory relative to $HOME
3 participants