-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List backup repositories of a module #749
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return the list of backup destinations with a Restic repository for the current module.
Split the run_restic() function to ease custom subprocess invocation.
andre8244
approved these changes
Nov 13, 2024
Run Restic backup faster with "--no-scan". This option avoid calculating the backup size in advance. This is a time consuming operation, unnecessary for a background job.
Add an optional "progress_callback" argument to agent.run_restic() function, to provide UI feedback of Restic's progress. Restic's output must switched to JSON format with "--json" argument.
Capture Restic progress during the restoration of a module instance. Tune progress intervals of cluster/restore-module action.
While Restic backup is invoked in background most of times, the UI still allows to run the backup immediately. In that case, a detailed backup progress feedback is needed. - Add fine-grained backup progess trace to module-backup command - Run the backup from UI directly with module-backup command - If module-backup runs interactively, skip progress calculation
18917d0
to
0b11f47
Compare
If the module has no backup information in some destination, rclone commands fail with invalid JSON output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
list-backup-repositories
action for modules. Returns the list the Restic repositories of the module instance, from different backup destinations. The action output format is the same ofcluster/list-backup-repositories
.Refs NethServer/dev#7072