Check ports allocation for NS8 Modules #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Some thoughts to discuss together.
- The PR makes the library a Redis client.
- The check is required only when a module (not the cluster) agent invokes
node/allocate-ports. - New and existing modules instances, only those with the new
portsadmrole, are interested by this limit.
f23137f to
8a24475
Compare
8a24475 to
ae2a41a
Compare
core/imageroot/var/lib/nethserver/node/actions/allocate-ports/50allocate
Outdated
Show resolved
Hide resolved
core/imageroot/var/lib/nethserver/node/actions/allocate-ports/50allocate
Outdated
Show resolved
Hide resolved
DavidePrincipi
requested changes
Nov 5, 2024
core/imageroot/var/lib/nethserver/node/actions/allocate-ports/50allocate
Outdated
Show resolved
Hide resolved
606368b to
e931675
Compare
DavidePrincipi
requested changes
Nov 6, 2024
core/imageroot/var/lib/nethserver/node/actions/allocate-ports/50allocate
Outdated
Show resolved
Hide resolved
core/imageroot/var/lib/nethserver/node/actions/allocate-ports/50allocate
Outdated
Show resolved
Hide resolved
The message is sent to the system journal and also in the API error stream, which is visible in the Python exception raised by agent.allocate_ports(), too.
Return an empty list if the module has no ports allocation. Suppress module-not-found warnings when a module is removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a check to the port allocation library to ensure modules don’t request more ports than allowed. When a module is installed, its maximum required TCP and UDP ports are stored in Redis. Then, when allocating new ports, the system checks that the total number of allocated ports plus the requested ports doesn’t exceed this limit. This prevents over-allocation and keeps port usage within safe limits.
Refs NethServer/dev#7092