feat(domains): update EditExternalDomain title and label for improved…

… clarity
NethServer · Feb 14, 2025 · 6658082 · 6658082
1 parent 90780ee
commit 6658082
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/core/ui/public/i18n/en/translation.json b/core/ui/public/i18n/en/translation.json
@@ -1173,7 +1173,8 @@
         "provider_already_installed": "Provider already installed",
         "no_node_eligible_for_provider_installation": "No node is eligible for provider installation",
         "domain_settings": "Domain settings",
-        "edit_external_domain": "Edit external domain"
+        "edit_external_domain": "Edit external domain {name}",
+        "edit_domain": "Edit domain"
     },
     "samba": {
         "adminuser": "Samba admin username",

diff --git a/core/ui/src/components/domains/EditExternalDomain.vue b/core/ui/src/components/domains/EditExternalDomain.vue
@@ -9,7 +9,7 @@
     @modal-hidden="$emit('hide')"
     @primary-click="alterExternalDomain"
   >
-    <template slot="title">{{ $t("domains.edit_external_domain") }}</template>
+    <template slot="title">{{ $t("domains.edit_external_domain", {name: domain.name}) }}</template>
     <template slot="content">
       <cv-form @submit.prevent="alterExternalDomain">
         <NsTextInput

diff --git a/core/ui/src/views/DomainConfiguration.vue b/core/ui/src/views/DomainConfiguration.vue
@@ -61,7 +61,7 @@
             <NsInfoCard
               v-else-if="!loading.listUserDomains"
               light
-              :icon="Events32"
+              :icon="Settings32"
               :title="$t('domains.domain_settings')"
             >
               <template #menu>
@@ -75,7 +75,7 @@
                     <cv-overflow-menu-item @click="showEditExternalDomain()">
                       <NsMenuItem
                         :icon="Edit20"
-                        :label="$t('domains.edit_external_domain')"
+                        :label="$t('domains.edit_domain')"
                       />
                     </cv-overflow-menu-item>
                   </cv-overflow-menu>
@@ -1340,6 +1340,6 @@ export default {
   padding-right: 0.75rem;
   font-weight: bold;
   text-align: right;
-  padding-bottom: 0.5rem;
+  padding-bottom: 1rem;
 }
 </style>