use data and callback directly from cfg

Netflix · Jul 25, 2024 · 7394c78 · 7394c78
1 parent 588a686
commit 7394c78
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/libvmaf/src/feature/feature_collector.c b/libvmaf/src/feature/feature_collector.c
@@ -373,7 +373,7 @@ int vmaf_feature_collector_append(VmafFeatureCollector *feature_collector,
                 .score = score,
           };
 
-          metadata_iter->callback(metadata_iter->data, &data);
+          metadata_iter->metadata_cfg.callback(metadata_iter->metadata_cfg.data, &data);
           model_iter = model_iter->next;
       }
       metadata_iter = metadata_iter->next;

diff --git a/libvmaf/src/metadata_handler.c b/libvmaf/src/metadata_handler.c
@@ -48,10 +48,6 @@ int vmaf_metadata_append(VmafCallbackList *metadata, const VmafMetadataConfigura
 
     node->metadata_cfg = metadata_cfg;
 
-    //FIXME, remove these
-    node->data = metadata_cfg.data;
-    node->callback = metadata_cfg.callback;
-
     if (!metadata->head) {
         metadata->head = node;
     } else {