sidecar: only log the first failure #1026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before we would reenable after successful calls so we could detect if the sidecar was having periodic problems. However, for UDP some calls can appear to be successful even if they have failed so it still leads to spammy logs. For now limit to the first failure. Fixes Netflix#1025.
brharrington
added a commit
to brharrington/spectator
that referenced
this pull request
Apr 6, 2023
Before we would reenable after successful calls so we could detect if the sidecar was having periodic problems. However, for UDP some calls can appear to be successful even if they have failed so it still leads to spammy logs. For now limit to the first failure. Fixes Netflix#1025.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we would reenable after successful calls so we could detect if the sidecar was having periodic problems. However, for UDP some calls can appear to be successful even if they have failed so it still leads to spammy logs. For now limit to the first failure.
Fixes #1025.