[argo] add terminationMessagePolicy (#50) (#1936)

- add a terminationMessagePolicy to FallbackToLogsOnError
Netflix · Jul 29, 2024 · cb15a4e · cb15a4e
1 parent 790a0f0
commit cb15a4e
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 0 deletions.
diff --git a/metaflow/plugins/argo/argo_workflows.py b/metaflow/plugins/argo/argo_workflows.py
@@ -2015,6 +2015,7 @@ def _container_templates(self):
                         kubernetes_sdk.V1Container(
                             name=self._sanitize(node.name),
                             command=cmds,
+                            termination_message_policy="FallbackToLogsOnError",
                             ports=[kubernetes_sdk.V1ContainerPort(container_port=port)]
                             if port
                             else None,

diff --git a/metaflow/plugins/kubernetes/kubernetes_job.py b/metaflow/plugins/kubernetes/kubernetes_job.py
@@ -98,6 +98,7 @@ def create_job_spec(self):
                     containers=[
                         client.V1Container(
                             command=self._kwargs["command"],
+                            termination_message_policy="FallbackToLogsOnError",
                             ports=[]
                             if self._kwargs["port"] is None
                             else [

diff --git a/metaflow/plugins/kubernetes/kubernetes_jobsets.py b/metaflow/plugins/kubernetes/kubernetes_jobsets.py
@@ -586,6 +586,7 @@ def dump(self):
                                 containers=[
                                     client.V1Container(
                                         command=self._kwargs["command"],
+                                        termination_message_policy="FallbackToLogsOnError",
                                         ports=[]
                                         if self._kwargs["port"] is None
                                         else [