Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add data modifier to input type for kotlin2 #788

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import kotlin.Pair
import kotlin.String
import kotlin.collections.List

public class PersonFilter @JsonCreator constructor(
public data class PersonFilter @JsonCreator constructor(
@JsonProperty("email")
public val email: String? = default<PersonFilter, String?>("email", null),
) : GraphQLInput() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import kotlin.Pair
import kotlin.String
import kotlin.collections.List

public class PersonFilter @JsonCreator constructor(
public data class PersonFilter @JsonCreator constructor(
@JsonProperty("email")
public val email: String? = default<PersonFilter, String?>("email", null),
@JsonProperty("birthYear")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import kotlin.collections.List
*
* It takes a title and such.
*/
public class MovieFilter @JsonCreator constructor(
public data class MovieFilter @JsonCreator constructor(
@JsonProperty("titleFilter")
public val titleFilter: String? = default<MovieFilter, String?>("titleFilter", null),
) : GraphQLInput() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import kotlin.Pair
import kotlin.String
import kotlin.collections.List

public class MovieFilter @JsonCreator constructor(
public data class MovieFilter @JsonCreator constructor(
@JsonProperty("titleFilter")
public val titleFilter: String? = default<MovieFilter, String?>("titleFilter", null),
) : GraphQLInput() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import kotlin.Pair
import kotlin.String
import kotlin.collections.List

public class MovieFilter @JsonCreator constructor(
public data class MovieFilter @JsonCreator constructor(
@JsonProperty("genre")
public val genre: String? = default<MovieFilter, String?>("genre", null),
) : GraphQLInput() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import kotlin.Pair
import kotlin.String
import kotlin.collections.List

public class OrderFilter @JsonCreator constructor(
public data class OrderFilter @JsonCreator constructor(
@JsonProperty("min")
public val min: BigDecimal = default<OrderFilter, BigDecimal>("min", java.math.BigDecimal("1.1")),
@JsonProperty("avg")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import kotlin.Pair
import kotlin.String
import kotlin.collections.List

public class SomeType @JsonCreator constructor(
public data class SomeType @JsonCreator constructor(
@JsonProperty("colors")
public val colors: List<Color?>? = default<SomeType, List<Color?>?>("colors",
listOf(com.netflix.graphql.dgs.codegen.cases.inputWithDefaultEnumValueForArray.expected.types.Color.red)),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import kotlin.Pair
import kotlin.String
import kotlin.collections.List

public class SomeType @JsonCreator constructor(
public data class SomeType @JsonCreator constructor(
@JsonProperty("numbers")
public val numbers: List<Int?>? = default<SomeType, List<Int?>?>("numbers", listOf(1, 2, 3)),
) : GraphQLInput() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import kotlin.Pair
import kotlin.String
import kotlin.collections.List

public class SomeType @JsonCreator constructor(
public data class SomeType @JsonCreator constructor(
@JsonProperty("names")
public val names: List<String?>? = default<SomeType, List<String?>?>("names", listOf("A", "B")),
) : GraphQLInput() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import kotlin.Pair
import kotlin.String
import kotlin.collections.List

public class SomeType @JsonCreator constructor(
public data class SomeType @JsonCreator constructor(
@JsonProperty("names")
public val names: List<String?>? = default<SomeType, List<String?>?>("names", emptyList()),
) : GraphQLInput() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import kotlin.Pair
import kotlin.String
import kotlin.collections.List

public class ColorFilter @JsonCreator constructor(
public data class ColorFilter @JsonCreator constructor(
@JsonProperty("color")
public val color: Color? = default<ColorFilter, Color?>("color",
com.netflix.graphql.dgs.codegen.cases.inputWithDefaultValueForEnum.expected.types.Color.red),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import kotlin.Pair
import kotlin.String
import kotlin.collections.List

public class Car @JsonCreator constructor(
public data class Car @JsonCreator constructor(
@JsonProperty("brand")
public val brand: String = default<Car, String>("brand", "BMW"),
) : GraphQLInput() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import kotlin.Pair
import kotlin.String
import kotlin.collections.List

public class Person @JsonCreator constructor(
public data class Person @JsonCreator constructor(
@JsonProperty("name")
public val name: String = default<Person, String>("name", "Damian"),
@JsonProperty("age")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import kotlin.Pair
import kotlin.String
import kotlin.collections.List

public class Car @JsonCreator constructor(
public data class Car @JsonCreator constructor(
@JsonProperty("brand")
public val brand: String = default<Car, String>("brand", "BMW"),
) : GraphQLInput() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import kotlin.Pair
import kotlin.String
import kotlin.collections.List

public class MovieFilter @JsonCreator constructor(
public data class MovieFilter @JsonCreator constructor(
@JsonProperty("director")
public val director: Person? = default<MovieFilter, Person?>("director",
com.netflix.graphql.dgs.codegen.cases.inputWithDefaultValueForObject.expected.types.Person(name
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import kotlin.Pair
import kotlin.String
import kotlin.collections.List

public class Person @JsonCreator constructor(
public data class Person @JsonCreator constructor(
@JsonProperty("name")
public val name: String? = default<Person, String?>("name", "John"),
@JsonProperty("age")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import kotlin.Pair
import kotlin.String
import kotlin.collections.List

public class MovieFilter @JsonCreator constructor(
public data class MovieFilter @JsonCreator constructor(
@JsonProperty("genre")
public val genre: String? = default<MovieFilter, String?>("genre", null),
@JsonProperty("releaseYear")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import kotlin.Pair
import kotlin.String
import kotlin.collections.List

public class SampleInput @JsonCreator constructor(
public data class SampleInput @JsonCreator constructor(
@JsonProperty("return")
public val `return`: String,
) : GraphQLInput() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import kotlin.Pair
import kotlin.String
import kotlin.collections.List

public class I1 @JsonCreator constructor(
public data class I1 @JsonCreator constructor(
@JsonProperty("arg1")
public val arg1: I1? = default<I1, I1?>("arg1", null),
@JsonProperty("arg2")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import kotlin.Pair
import kotlin.String
import kotlin.collections.List

public class I2 @JsonCreator constructor(
public data class I2 @JsonCreator constructor(
@JsonProperty("arg1")
public val arg1: String? = default<I2, String?>("arg1", null),
@JsonProperty("arg2")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import kotlin.Pair
import kotlin.String
import kotlin.collections.List

public class I @JsonCreator constructor(
public data class I @JsonCreator constructor(
@JsonProperty("arg")
public val arg: String? = default<I, String?>("arg", null),
) : GraphQLInput() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import kotlin.Pair
import kotlin.String
import kotlin.collections.List

public class I @JsonCreator constructor(
public data class I @JsonCreator constructor(
@JsonProperty("arg")
public val arg: String? = default<I, String?>("arg", null),
) : GraphQLInput() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ fun generateKotlin2InputTypes(
addKdoc("%L", inputDefinition.description.sanitizeKdoc())
}
}
.addModifiers(KModifier.DATA)
.superclass(GraphQLInput::class)
// add a constructor with a parameter for every field
.primaryConstructor(
Expand Down