incorrect use of Clojure :arglists metadata? #831
Comments
|
Thanks @stuarthalloway for the heads up on this. @daveray Can you help look into this? |
|
Sorry for the slow response. Vacation + sickness. I'll take a look this week. |
|
@daveray Are you still able to take a look? |
daveray
added a commit
to daveray/Hystrix
that referenced
this issue
Aug 6, 2015
This is a fix for issue Netflix#831 (Netflix#831) which is a blocker for http://dev.clojure.org/jira/browse/CLJ-1232. Instead of generating :arglists as (list (quote [..])*), generate (quote ([..]*)). Tests still pass and (doc command) works as intended. I have not directly tested this with Clojure patched with CLJ-1232.
|
Hi. @stuarthalloway there's a proposed fix here: daveray@11d5bad |
|
Thanks @daveray. I don't know enough Clojure to evaluate the fix - are you comfortable with me merging and releasing, or would you prefer to wait until some validation can be done? |
|
@mattrjacobs I'm comfortable with merge and release. |
|
Merged in #852 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The proposed fix to Clojure bug http://dev.clojure.org/jira/browse/CLJ-1232 appears to break hystrix-clj, which (if the ticket comments are correct) uses arglists metadata in a way different from the Clojure compiler.
At first glance this seems to be a bug in hystrix-clj that will become breaking once http://dev.clojure.org/jira/browse/CLJ-1232 is applied. Looking for input/context before we do that.
The text was updated successfully, but these errors were encountered: