Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update releasing.md #632

Closed
wants to merge 1 commit into from
Closed

Conversation

uniyalmani
Copy link
Contributor

Summary

Update CI/CD from Travis CI to GitHub Actions in documentation.

Details

  • Updated Travis CI to GitHub Actions in documentation.

Related Issue

Addresses #500

@aorinevo
Copy link
Collaborator

aorinevo commented Jan 9, 2024

Hi @uniyalmani, much appreciate the contribution. I did a quick search of 'travis' in the codebase and found a couple of more instances. Can you take a look into them?

@aorinevo aorinevo self-requested a review January 9, 2024 14:48
@aorinevo aorinevo self-assigned this Jan 9, 2024
Copy link
Collaborator

@aorinevo aorinevo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

@aorinevo
Copy link
Collaborator

aorinevo commented Jan 9, 2024

Also, just an FYI the CD portion is currently borked on account of permissions issues. While we are able to land changes and tag them, we are not currently able to publish the tags to the npm registry. I'm working with folks at NerdWallet to get that resolved.

@uniyalmani
Copy link
Contributor Author

Hi @uniyalmani, much appreciate the contribution. I did a quick search of 'travis' in the codebase and found a couple of more instances. Can you take a look into them?

okay sir

@uniyalmani
Copy link
Contributor Author

Updated remaining files as per your guidance.

@@ -2,7 +2,7 @@

<img alt="Illustration of a sheep" width=320 align=right src="https://user-images.githubusercontent.com/332258/46430732-c7bf5c80-c6fe-11e8-9cc8-2abc4e68dce2.jpg">

![Travis status](https://img.shields.io/travis/NerdWalletOSS/shepherd/master.svg?style=flat-square)
[![GitHub Workflow Status](https://img.shields.io/github/actions/workflow/status/NerdWalletOSS/shepherd/release.yml?style=flat-square)](https://github.com/NerdWalletOSS/shepherd/actions)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool!

Copy link
Collaborator

@aorinevo aorinevo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you, @uniyalmani!

Note, I will cherry-pick these changes into a branch on upstream and open a PR to main from there. Once reviewed, approved, and merged, this PR will be auto-closed.

@aorinevo
Copy link
Collaborator

@uniyalmani, I need these commits to be squashed into 1. Can you do me a solid and squash them?

Update CI/CD from Travis CI to GitHub Actions in documentation.

Update README.md

docs: Update GitHub Actions badge in README.md

Replaced the Travis CI badge with the GitHub Actions badge for the release workflow in the README.md file.

Update renovate.json

chore(ci): Update CI configuration for GitHub Actions
@uniyalmani
Copy link
Contributor Author

@uniyalmani, I need these commits to be squashed into 1. Can you do me a solid and squash them?

Done

@aorinevo
Copy link
Collaborator

Closed by #637

@aorinevo aorinevo closed this Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants