Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fmpq_mul_si #1776

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Use fmpq_mul_si #1776

merged 1 commit into from
Jun 5, 2024

Conversation

joschmitt
Copy link
Collaborator

I noticed that *(::QQFieldElem, ::Int) calls generic AbstractAlgebra code instead of flint.

Before

julia> a = QQ(1, 2)
1//2

julia> @btime 2*a;
  116.807 ns (11 allocations: 192 bytes)

After

julia> @btime 2*a;
  20.632 ns (1 allocation: 32 bytes)

This is related to thofma/Hecke.jl#1537 .

@fingolfin fingolfin merged commit 0ecd0cc into Nemocas:master Jun 5, 2024
24 checks passed
@joschmitt joschmitt deleted the js/fmpqmulsi branch June 6, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants