Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalizing lid states for glass containers. #4854

Merged
merged 2 commits into from
Feb 13, 2025
Merged

Generalizing lid states for glass containers. #4854

merged 2 commits into from
Feb 13, 2025

Conversation

MistakeNot4892
Copy link
Contributor

@MistakeNot4892 MistakeNot4892 commented Feb 11, 2025 •
edited
Loading

  • Buckets draw handles as overlays.
  • /glass objects use a separate proc for updating overlays.
  • Lid overlays moved to /glass.
  • can_lid() overrides added where appropriate.
  • CI error added for liddables with no lid icon.
  • Fixes Incorrect bucket icons #4852

@MistakeNot4892 MistakeNot4892 added the work in progress This PR is under development and shouldn't be merged. label Feb 11, 2025
@MistakeNot4892 MistakeNot4892 force-pushed the fix/buckets branch 4 times, most recently from 59bd878 to 21f5fe4 Compare February 11, 2025 05:14
@MistakeNot4892 MistakeNot4892 added ready for review This PR is ready for review and merge. and removed work in progress This PR is under development and shouldn't be merged. labels Feb 11, 2025
@out-of-phaze out-of-phaze merged commit 7384b4a into NebulaSS13:staging Feb 13, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@out-of-phaze out-of-phaze out-of-phaze approved these changes

Assignees
No one assigned
Labels
ready for review This PR is ready for review and merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MistakeNot4892 @out-of-phaze