Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate beds and chairs out of furniture.dmi, groundwork for eventual de-bedding of chairs #4835

Merged

Conversation

out-of-phaze
Copy link
Member

Description of changes

Removes base_icon from beds.
Makes single pews/benches into chairs.
Splits up furniture.dmi.
Moves some grab-buckle logic onto structures.
Makes the travois not a bed.
Adds a description to the travois.

Why and what will this PR improve

general code quality improvement, plus eventually we will be able to destroy /obj/structure/bed/chair/bench/pew.

@out-of-phaze out-of-phaze added the ready for review This PR is ready for review and merge. label Feb 3, 2025
@out-of-phaze out-of-phaze force-pushed the codequality/chair-icon-split branch from 170dea9 to 70162a5 Compare February 3, 2025 07:23
@@ -7,7 +7,7 @@
throwpass = TRUE
anchored = TRUE
atom_flags = ATOM_FLAG_CLIMBABLE | ATOM_FLAG_CHECKS_BORDER
can_buckle = TRUE
can_buckle = TRUE // TODO: Is it actually... intended that you can buckle stuff to this?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Believe it's so you can avoid being shoved out of a defensive position

@MistakeNot4892 MistakeNot4892 merged commit 69466a2 into NebulaSS13:dev Feb 4, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR is ready for review and merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants