Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PhysicsSnapshot #878

Merged
merged 20 commits into from
Jan 20, 2025
Merged

Add PhysicsSnapshot #878

merged 20 commits into from
Jan 20, 2025

Conversation

McCallisterRomer
Copy link
Member

resolves #876

Adding rollback support for NcPhysics

  • Adding PhysicsTick and PhysicsSnapshot for state tracking.
  • Added functions to NcPhysics to facilitate manual updates/ticks.
    • Rustbelt has its own rollback strategy outside of what the engine really ought to care about at this point. With new functions, we can wrap NcPhysics in a custom physics module, giving us control over when/how many physics ticks happen.
    • Original functionality is still the default, with an opt-in in PhysicsSettings.

Copy link
Member

@jaremieromer jaremieromer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditionally approving based on answer to this question:
The app crashes if enable_network_rollback is 1. I'm assuming this is because of the single player bug you're fixing now. If that's the case, I'm good with pushing in this state and waiting on the single player fix.

test/ncengine/physics/jolt/PhysicsSnapshot_unit_tests.cpp Outdated Show resolved Hide resolved
@McCallisterRomer McCallisterRomer merged commit bda3d8a into vnext Jan 20, 2025
10 checks passed
@McCallisterRomer McCallisterRomer deleted the cal/snapshots branch January 20, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Physics Snapshots/Rollback
2 participants