Component Ids #498
Merged
Component Ids #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #420
Another piece needed for serialization. When deserializing component data, we need a way to map the individual blobs back to something that knows what to do with them (pool/handler). Adding an integer id that can be either automatically assigned or manually overridden.
All engine types have explicitly set ids. I added these as static members to each type, which isn't necessary, but it seems like a potentially useful pattern for templated code (for example, see RegistryFactories.cpp in this changeset).
Added a few utility functions to
ComponentRegistryandAnyComponentfor future use of the id.Unrelated to the id, but I also changed the order in which components are registered. This influences the order of component widgets in the editor (would be nice to be able to change that, but that's a whole thing...).