Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Json update + static analysis #7

Merged
merged 8 commits into from
Jan 16, 2023
Merged

Json update + static analysis #7

merged 8 commits into from
Jan 16, 2023

Conversation

McCallisterRomer
Copy link
Member

  • Including json headers directly instead of through fetch_content. With fetch_content, we must do a cmake install to make the headers available to NcEngine, which clutters up the install directory over there with files we don't care about. There's a recommended way to fetch just the header-only stuff, but it seems to be broken.
  • Adding msvc static analyzer and bumping warnings to /W4
  • Added a few warnings for mingw.
  • Fixing stuff found with higher warnings.

@McCallisterRomer McCallisterRomer merged commit f30ac63 into vnext Jan 16, 2023
@McCallisterRomer McCallisterRomer deleted the cal/json_lib branch January 28, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants