Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polygons around barcodes #21

Closed
quicklizard99 opened this issue Mar 21, 2018 · 5 comments
Closed

Polygons around barcodes #21

quicklizard99 opened this issue Mar 21, 2018 · 5 comments

Comments

@quicklizard99
Copy link
Member

In addition to bounding boxes, make available a list of points describing the polygon around the barcode. Requested by @poynting (see #11)
quicklizard99 added a commit that referenced this issue Mar 21, 2018
@quicklizard99
#21 Polygons around barcodes
c4f45d5
@quicklizard99 quicklizard99 mentioned this issue Mar 21, 2018
Merged
@quicklizard99
Copy link
Member Author

quicklizard99 commented Mar 21, 2018 •
edited
Loading

@poynting I think this change will satisfy the requirement - please see the associated pull request (#22)

@poynting
Copy link

This looks good to me and works for my needs. Thanks!

quicklizard99 added a commit that referenced this issue Apr 30, 2018
@quicklizard99
#21 Additional rotated barcode
9bcc9ee
quicklizard99 added a commit that referenced this issue Apr 30, 2018
@quicklizard99
#21 Point._make for all return paths
f8741f5
quicklizard99 added a commit that referenced this issue Apr 30, 2018
@quicklizard99
#21 Removing redundant import and fix docstring
99776c0
quicklizard99 added a commit that referenced this issue Apr 30, 2018
@quicklizard99
#21 Package description
49493b9
quicklizard99 added a commit that referenced this issue Apr 30, 2018
@quicklizard99
#21 Illustrate bounding box and polygon
e032226
quicklizard99 added a commit that referenced this issue Apr 30, 2018
@quicklizard99
#21 Illustrate bounding box and polygon
4823496
quicklizard99 added a commit that referenced this issue Apr 30, 2018
@quicklizard99
#21 Illustrate bounding box and polygon
594464d
quicklizard99 added a commit that referenced this issue Apr 30, 2018
@quicklizard99
#21 Illustrate bounding box and polygon
3f527c1
quicklizard99 added a commit that referenced this issue Apr 30, 2018
@quicklizard99
#21 Illustrate bounding box and polygon
a98d986
@poynting
Copy link

poynting commented May 7, 2018

Hi @quicklizard99 - do you have a time frame for your 1.6 release? This is working great for our needs, and we would like to release some code dependent upon it. The two environments I can test under are

Python 3 / Windows 10 / Anaconda
Python 2.7 / Ubuntu 14.04

and both of these work with this branch. If there's more that I can help with preparing for release, let me know.

@quicklizard99
Copy link
Member Author

Hi @poynting - apologies for the delay in getting this out. Thanks very much for the testing and feedback. I will try to get a release within the next week.

quicklizard99 added a commit that referenced this issue May 10, 2018
@quicklizard99
Merge pull request #22 from NaturalHistoryMuseum/feature/21-polygons
6fbb6e1 
#21 Polygons around barcodes
@quicklizard99
Copy link
Member Author

@poynting 0.1.7 now on PyPI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@quicklizard99 @poynting