[97] Fixes schemeURI is never generated in the XML payload #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @t-book! Thanks for this PR, it's really appreciated. |
|
@alycejenni thanks for accepting ! more to come ;) |
|
@t-book if you're planning to make more contributions (which are definitely welcome, thank you!), could I ask that you have a quick read of our guidelines for commits and PRs first? We know we need to make these a little more obvious to new contributors, but I thought I'd point them out if you're planning to make some more changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the missing schemeURI attribute in datacite XML as explained in the issue #97