Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set JsonOutputFilter to use DateFilterFilenameGenerator #621

Conversation

cfkoehler
Copy link
Collaborator

@cfkoehler cfkoehler commented Nov 7, 2023

On the path to normalize and use a single FilenameGenerator.
First step since no downstream component uses the jsonOutputFilter

@cfkoehler cfkoehler marked this pull request as ready for review February 10, 2024 18:55
@cfkoehler
Copy link
Collaborator Author

cfkoehler commented Feb 10, 2024

Example filename that is generated for json output:
20240411848_fbe1343e-95e2-4de9-9fb1-531f359410fc_localhost_json_5f7c7752-23cf-4026-b27d-996109d90eab.bgpart

old filename:
202402101900000localhost.json_933aca4c-e5fb-4e55-a5f0-c7110c9b70c7.bgpart

Everything after 'json' is added by journaler as the journalFileName. I think ideally that ending uuid is not needed.

@jpdahlke jpdahlke added this to the v8.0.0-M14 milestone Feb 13, 2024
@jpdahlke jpdahlke self-requested a review February 13, 2024 13:46
@fbruton fbruton self-requested a review February 14, 2024 17:13
@jpdahlke jpdahlke merged commit 19eeee8 into NationalSecurityAgency:master Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants